Skip to content

fix json tests #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
knqyf263 wants to merge 1 commit into from
Closed

fix json tests #4

knqyf263 wants to merge 1 commit into from

Conversation

@knqyf263
Copy link
Contributor

@knqyf263 knqyf263 commented Apr 28, 2021

Before:

$ go test ./...
# golang.org/x/vulndb/osv [golang.org/x/vulndb/osv.test]
osv/json_test.go:18:3: cannot use []struct { Module string; Package string; Symbols []string; Versions []report.VersionRange }{...} (type []struct { Module string; Package string; Symbols []string; Versions []report.VersionRange }) as type []struct { Module string "yaml:\",omitempty\""; Package string "yaml:\",omitempty\""; Symbols []string "yaml:\",omitempty\""; Versions []report.VersionRange "yaml:\",omitempty\"" } in field value
osv/json_test.go:46:3: cannot use struct { PR string; Commit string; Context []string }{...} (type struct { PR string; Commit string; Context []string }) as type struct { PR string "yaml:\",omitempty\""; Commit string "yaml:\",omitempty\""; Context []string "yaml:\",omitempty\"" } in field value
ok      golang.org/x/vulndb/client      (cached)
?       golang.org/x/vulndb/cmd/gendb   [no test files]
?       golang.org/x/vulndb/cmd/genhtml [no test files]
?       golang.org/x/vulndb/cmd/linter  [no test files]
?       golang.org/x/vulndb/cmd/report2cve      [no test files]
FAIL    golang.org/x/vulndb/osv [build failed]
?       golang.org/x/vulndb/report      [no test files]
FAIL

After:

$ go test ./...
ok      golang.org/x/vulndb/client
?       golang.org/x/vulndb/cmd/gendb   [no test files]
?       golang.org/x/vulndb/cmd/genhtml [no test files]
?       golang.org/x/vulndb/cmd/linter  [no test files]
?       golang.org/x/vulndb/cmd/report2cve      [no test files]
ok      golang.org/x/vulndb/osv 0.243s
?       golang.org/x/vulndb/report      [no test files]

@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@knqyf263 knqyf263 mentioned this pull request Apr 28, 2021
Closed
@gopherbot
Copy link
Contributor

gopherbot commented Apr 28, 2021

This PR (HEAD: 90393cf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vulndb/+/314669 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@GoVulnBot GoVulnBot mentioned this pull request Dec 30, 2022
Closed
gopherbot pushed a commit that referenced this pull request Jan 13, 2023
@tatianab
data/reports: add alias and fix symbol in GO-2020-0004.yaml
bfcb8f1 
Adds GHSA and fixes typo in symbol.

Aliases: CVE-2020-36569, GHSA-hrm3-3xm6-x33h

Updates #4
Fixes #1227
Updates #1282

Change-Id: I027596c711959a8704c674a7e377dcb0dca535e6
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/461235
Run-TryBot: Tatiana Bradley <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Tatiana Bradley <[email protected]>
@ethanalee-work
Copy link
Contributor

ethanalee-work commented Aug 15, 2025

Closing as obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knqyf263 @gopherbot @ethanalee-work